feat: add modern client lifecycle modes (SEP-2575)#995
Conversation
github-actions
Bot
added
T-test
c702157 to
ce7fd9c
Compare
github-actions
Bot
added
T-documentation
ce7fd9c to
fb26041
Compare
fb26041 to
5d6a6e0
Compare
DaleSeo
changed the title
| --scenario sep-2322-client-request-state \ | ||
| -o conformance-client-results/mrtr | ||
| - name: Run draft SEP-2575 client scenario |
There was a problem hiding this comment.
How does this combine/relate to https://github.com/modelcontextprotocol/rust-sdk/pull/991/changes#diff-bd4df60e4b8977afa547a4b2976c2aed79b2113b0fffad61810242961e7fc930R925 ?
cc @jamadeo
Ideally we'd just set the conformance tests to run all the scenarios relevant for the new version and see the list of failures get smaller as we check in support for things.
There was a problem hiding this comment.
@alexhancock That PR added an interim plumbing so the scenarios could run at all without SDK changes. This PR actually replaces that harness, allowing all routes to go through the real public API.
Regarding running the whole draft suite, I thought about it, but the runner exits with a non-zero status on any failure. So, running all draft scenarios today would keep CI red until the remaining SEPs are completed. I'm fine with that, but we would need to be a bit careful not to miss any regressions.
| Ok(()) | ||
| } | ||
|
|
||
| async fn modern_startup<S, T>( |
There was a problem hiding this comment.
Thoughts renaming the old code legacy_ instead of the new code modern_?
It strikes me it would be easier to deprecate and remove the legacy stuff if done this way vs having to ship all this and then rename it all when we don't want it to be called "modern" any more.
There was a problem hiding this comment.
Makes sense! Thanks for the suggestion. Will rename it.
b1bc9fd to
9b69a72
Compare
4271da6 to
a74e36f
Compare
a74e36f to
be98a64
Compare
2 participants
Motivation and Context
This builds on PR #973 for discovery and negotiation by letting clients start with
server/discoverinstead of the legacyinitializehandshake. Modern requests carry self-contained client metadata, while auto mode can fall back for legacy servers and the existing legacy lifecycle remains the default.How Has This Been Tested?
The modern, auto-fallback, per-request metadata, and stateless Streamable HTTP paths are covered by integration tests.
Breaking Changes
No breaking changes. Existing clients continue to use the legacy lifecycle flow unless they explicitly select a modern lifecycle mode.
Types of changes
Checklist